skoppu22 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321860937
##########
src/java/org/apache/cassandra/auth/CassandraCIDRAuthorizer.java:
##########
@@ -154,4 +154,10 @@ public boolean hasAccessFromIp(RoleResource role,
InetAddress ipAddress)
TimeUnit.NANOSECONDS);
return hasAccess;
}
+
+ @VisibleForTesting
+ public boolean has(RoleResource role)
Review Comment:
We wouldn't need this has() function if we plan to not check for entry
existence in the cache in unit tests to avoid flaky test. I will wait for your
confirmation on the final approach before making changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
