skoppu22 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321846717
##########
src/java/org/apache/cassandra/tools/nodetool/InvalidateCIDRPermissionsCache.java:
##########
@@ -39,8 +39,8 @@ public void execute(NodeProbe probe)
{
if (args.isEmpty())
{
- probe.invalidateCidrPermissionsCache("");
- probe.output().out.println("Invalidated CIDR permissions cache");
+ if(probe.invalidateCidrPermissionsCache(""))
Review Comment:
Yes, but this line 42 gets executed when args.isEmpty, i.e, user wants to
invalidate entire cache, so
cidrPermissionsCache.invalidateCidrPermissions(roleName) is not called in this
case. cidrPermissionsCache.invalidateCidrPermissions(roleName) is called in the
below else condition and we check for return value there - line 49.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
