grom358 commented on code in PR #2625:
URL: https://github.com/apache/cassandra/pull/2625#discussion_r1328356732
##########
src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java:
##########
@@ -132,17 +140,20 @@ protected UnfilteredRowIterator getReduced()
? null
:
listener.getRowMergeListener(partitionKey, toMerge);
- // Make a single empty iterator object to merge, we don't need
toMerge.size() copiess
- UnfilteredRowIterator empty = null;
-
- // Replace nulls by empty iterators
- for (int i = 0; i < toMerge.size(); i++)
+ if (listener != null && listener.preserveOrder())
Review Comment:
yeah going ignore this one for now. I was trying todo that initially when
creating the pull request but due to complexity I skipped it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
