blambov commented on code in PR #2625:
URL: https://github.com/apache/cassandra/pull/2625#discussion_r1333188247
##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -169,7 +180,7 @@ public UnfilteredRowIterators.MergeListener
getRowMergeListener(DecoratedKey par
CompactionIterator.this.updateCounterFor(merged);
- if (type != OperationType.COMPACTION ||
!controller.cfs.indexManager.hasIndexes())
+ if (!rowProcessingNeeded())
Review Comment:
No. Order preservation does not determine if we return here, the need for
row processing determines both if we return here and if we should preserve
order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
