blambov commented on code in PR #2625:
URL: https://github.com/apache/cassandra/pull/2625#discussion_r1328435884
##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -154,6 +154,12 @@ private UnfilteredPartitionIterators.MergeListener
listener()
{
return new UnfilteredPartitionIterators.MergeListener()
{
+ @Override
+ public boolean preserveOrder()
+ {
+ return type == OperationType.COMPACTION &&
controller.cfs.indexManager.hasIndexes();
Review Comment:
Apologies, the comment is not clear at all. The code for choosing to return
null is different in C* 5, and at the moment there's no way to see that the
code for `preserveOrder` should be updated to match it (the patch will merge
cleanly but won't be correct).
We should extract this `type == OperationType.COMPACTION &&
controller.cfs.indexManager.hasIndexes()` decision into a method, and call it
from here as well as `listener()`. That way we will get a merge conflict when
this is being ported up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
