blambov commented on code in PR #2625:
URL: https://github.com/apache/cassandra/pull/2625#discussion_r1329716688
##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -175,7 +175,7 @@ public UnfilteredRowIterators.MergeListener
getRowMergeListener(DecoratedKey par
CompactionIterator.this.updateCounterFor(merged);
- if (type != OperationType.COMPACTION ||
!controller.cfs.indexManager.hasIndexes())
+ if (!preserveOrder())
Review Comment:
This would be extremely confusing to readers. Why does order preservation
determine if we should create a row listener?
Create a new method called e.g. `rowProcessingNeeded()`, and call it from
`preserveOrder()` as well as here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
