blambov commented on code in PR #2625:
URL: https://github.com/apache/cassandra/pull/2625#discussion_r1329725888
##########
src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java:
##########
@@ -45,10 +45,27 @@ private UnfilteredPartitionIterators() {}
public interface MergeListener
{
+ /**
+ * Check wether the merge listener requires rreservation of iterator
index.
Review Comment:
Nit: wether -> whether, rreservation -> preservation
"Index" here is a bit confusing as it may refer to the secondary index,
which is the usual reason to preserve order. I would phrase this as "Returns
true if the merger needs to preserve the position of sources within the merge
when passing data to the listener."
I would also add why it matters, e.g.: "If false, the merger can avoid
creating empty sources for non-present partitions and significantly speed up
processing."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
