ekaterinadimitrova2 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1321867958
##########
test/unit/org/apache/cassandra/tools/nodetool/InvalidateCIDRPermissionsCacheTest.java:
##########
@@ -118,10 +115,13 @@ public void testInvalidateSingleCidrPermission()
// ensure cidr permission is cached
role.hasAccessFromIp(ipAddr);
assertThat(originalReadsCount).isEqualTo(getCidrPermissionsReadCount());
+ assertThat(((CassandraCIDRAuthorizer)
DatabaseDescriptor.getCIDRAuthorizer()).has(ROLE_A)).isTrue();
// invalidate cidr permission
ToolRunner.ToolResult tool =
ToolRunner.invokeNodetool("invalidatecidrpermissionscache",
ROLE_A.getRoleName());
tool.assertOnCleanExit();
+ assertThat(tool.getStdout()).contains("Invalidated the role role_a
from CIDR permissions cache");
Review Comment:
`I believe that should be sufficient in the unit test. `
My only concern is that it wasn't to catch the bug we found here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
