mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1355023243
##########
src/java/org/apache/cassandra/index/sai/IndexContext.java:
##########
@@ -354,6 +371,11 @@ public boolean isLiteral()
return TypeUtil.isLiteral(getValidator());
}
+ public boolean isVector()
+ {
+ return getValidator().isVector() &&
((VectorType<?>)getValidator()).elementType instanceof FloatType;
Review Comment:
There is also an argument that says that it should be treated as a
collection and the index type be based on the element type.
For the CEP leaving it as ANN only for float and no other indexes allowed on
vectors, and we raise a follow on ticket to support other index types on
vectors (probably with a dev discussion first).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
