adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1356733277
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java:
##########
@@ -90,17 +99,29 @@
import org.apache.cassandra.schema.ColumnMetadata;
import org.apache.cassandra.schema.IndexMetadata;
import org.apache.cassandra.schema.TableMetadata;
+import org.apache.cassandra.service.ClientWarn;
import org.apache.cassandra.service.StorageService;
import org.apache.cassandra.utils.Pair;
import org.apache.cassandra.utils.concurrent.OpOrder;
+import static
org.apache.cassandra.index.sai.disk.v1.IndexWriterConfig.MAX_TOP_K;
+
public class StorageAttachedIndex implements Index
{
public static final String NAME = "sai";
+ public static final String VECTOR_USAGE_WARNING = "SAI ANN indexes on
vector columns are experimental and are not recommended for production use.\n" +
Review Comment:
I was thinking that we could format the limitations as a bullet list, and
mention aggregate functions and `GROUP BY` instead of aggregation queries,
which is kind of internal terminology. Something like:
```java
public static final String VECTOR_USAGE_WARNING = "SAI ANN indexes on vector
columns are experimental and are not recommended for production use.\n" +
"They don't yet support
SELECT queries with:\n" +
" * Consistency level
higher than ONE/LOCAL_ONE.\n" +
" * Paging.\n" +
" * No LIMIT clauses.\n" +
" * PER PARTITION LIMIT
clauses.\n" +
" * GROUP BY clauses.\n" +
" * Aggregation
functions.\n" +
" * Filters on columns
without a SAI index.\n" +
"These limitations are
planned to be removed in future versions.";
```
And perhaps we should say that _most of_ these limitations are planned to be
removed in future versions, since it's not clear that we will able to get rid
of all of them. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
