amitdpawar commented on code in PR #2777: URL: https://github.com/apache/cassandra/pull/2777#discussion_r1358286295
########## conf/cassandra.yaml: ########## @@ -2110,3 +2110,6 @@ drop_compact_storage_enabled: false # a stable cluster. If a node from a previous version was started by accident we won't any longer toggle behaviors as when UPGRADING. # storage_compatibility_mode: CASSANDRA_4 + +# Enable Direct I/O feature for Commitlog files. Java-11 forces minimum alignement to 4K and minimum disk write to 4K. +direct_io_for_commitlog_enabled: true Review Comment: I added commitlog disk access mode flag to take care existing "standard" for "Compressed" and "Encrypted" segments. Then, mmap for current default and direct_io as a new mode for this PR. These options made it easier to test with existing testcases only. If still required, then will change as per the earlier suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
