jacek-lewandowski commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1360453774


##########
conf/cassandra.yaml:
##########
@@ -589,6 +589,10 @@ commitlog_segment_size: 32MiB
 #     parameters:
 #         -
 
+# Configure commitlog disk access mode preferred order:direct_io, mmap, 
standard.
+# Default access mode is mmap. Direct I/O uses minimum page size to flush to 
disk.
+commitlog_disk_access_mode : mmap

Review Comment:
   Given what @blambov mentioned and the test results - is there any reason to 
not immediately deprecate this setting in favour of hardcoding it to direct in 
the next release?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to