jacek-lewandowski commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1360460338
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1149,6 +1151,13 @@ public enum DiskAccessMode
standard,
}
+ public enum CommitLogDiskAccessMode
Review Comment:
Maybe we can avoid creating another enum? The existing `DiskAccessMode` can
be probably used as well with added `direct` option and some validation in
places where it is used whether the selected access mode is supported or not?
(TBH, I'd rather remove `mmap_index_only` from `DiskAccessMode` to make it more
generic - disk access mode for indexes could be specified explicitly instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
