Maxwell-Guo commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1360478435


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1149,6 +1151,13 @@ public enum DiskAccessMode
         standard,
     }
 
+    public enum CommitLogDiskAccessMode

Review Comment:
   Is this flexible? As directio is only work for commitlog write, It May not 
be supported  for normal sstable read /write and commitlog read and others 
situation yet if DiskAccessMode is direct_io.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to