dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1372146479
##########
test/unit/org/apache/cassandra/repair/FuzzTestBase.java:
##########
@@ -319,25 +329,16 @@ static void enableMessageFaults(Cluster cluster)
@Override
public Set<Faults> apply(Cluster.Node node, Message<?> message)
{
+ if (RepairMessage.ALLOWS_RETRY.contains(message.verb()))
+ {
+ allowDrop.add(message.id());
+ return Faults.DROPPED;
+ }
switch (message.verb())
{
- case PREPARE_MSG:
- case VALIDATION_REQ:
- case VALIDATION_RSP:
- case SYNC_REQ:
- case SYNC_RSP:
- case SNAPSHOT_MSG:
- case CLEANUP_MSG:
- allowDrop.add(message.id());
- return Faults.DROPPED;
// these messages are not resilent to ephemeral issues
- case PREPARE_CONSISTENT_REQ:
- case PREPARE_CONSISTENT_RSP:
- case FINALIZE_PROPOSE_MSG:
- case FINALIZE_PROMISE_MSG:
- case FINALIZE_COMMIT_MSG:
- case FAILED_SESSION_MSG:
-
+ case STATUS_REQ:
Review Comment:
these messages actually no-op as `StorageService` is not initialized... they
actually cause annoying cases as they fail sessions, so didn't try to get
working... just didn't want tests to fail if those messages happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
