dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1377935929
##########
src/java/org/apache/cassandra/repair/messages/RepairMessage.java:
##########
@@ -232,4 +298,15 @@ private static ErrorHandling
errorHandlingSupported(SharedContext ctx, InetAddre
return ErrorHandling.TIMEOUT;
return ErrorHandling.NONE;
}
+
+ public static void sendFailureResponse(SharedContext ctx, Message<?>
respondTo)
Review Comment:
thats fine, we drop in the messaging layer... these are *replies* which
require we have Callbacks define for the message number, so the below block is
what we hit in 4.x
```
RequestCallbacks.CallbackInfo callbackInfo =
MessagingService.instance().callbacks.remove(message.id(), message.from());
if (callbackInfo == null)
{
String msg = "Callback already removed for {} (from {})";
logger.trace(msg, message.id(), message.from());
Tracing.trace(msg, message.id(), message.from());
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
