dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1372148939
##########
test/unit/org/apache/cassandra/repair/FuzzTestBase.java:
##########
@@ -850,7 +867,14 @@ private <REQ, RSP> void maybeEnqueue(Message<REQ> message,
InetAddressAndPort to
if (ctx != null)
{
assert ctx == cb;
- ctx.onFailure(to,
RequestFailureReason.TIMEOUT);
+ try
+ {
+ ctx.onFailure(to,
RequestFailureReason.TIMEOUT);
+ }
+ catch (Throwable t)
+ {
+ failures.add(t);
Review Comment:
when IR messages retry they would NPE as they use a null `desc`... this
would get handled by the future and ignored, so tests would fail saying the
repair didn't complete rather than the NPE... this fix makes sure we fail fast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
