smiklosovic commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462068283
##########
src/java/org/apache/cassandra/cache/ChunkCache.java:
##########
@@ -172,7 +171,7 @@ public void onRemoval(Key key, Buffer buffer, RemovalCause
cause)
buffer.release();
}
- public void close()
+ public void clear()
Review Comment:
I cant find any usage of that method. You are technically right, yes. But
looking at it, why not to rename it to `clear`?
The impl invalidates the cache which is kind of a clearing ... I think
"clear" makes more sense and reflects what that method does than "close". That
cache does not implement `(Auto)Closeable` or anything like that, there is
nothing to _close_. I think that was the original idea behind this change. Keep
in mind I just put it all together after Sam did his improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
