smiklosovic commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462094469
##########
src/java/org/apache/cassandra/tools/NodeProbe.java:
##########
@@ -1734,10 +1734,11 @@ public long getReadRepairRepairedBackground()
// JMX getters for the o.a.c.metrics API below.
/**
* Retrieve cache metrics based on the cache type (KeyCache, RowCache, or
CounterCache)
- * @param cacheType KeyCach, RowCache, or CounterCache
+ * @param type type, like Cache or UnweightedCache
+ * @param scope KeyCach, RowCache, or CounterCache
* @param metricName Capacity, Entries, HitRate, Size, Requests or Hits.
*/
- public Object getCacheMetric(String cacheType, String metricName)
+ public Object getCacheMetric(String type, String scope, String metricName)
Review Comment:
I think this is leftover from times when I was trying to expose unweighted
caches as well into nodetool's `Info` so it was not always called with "Cache"
but I removed that functionality from `Info` because I just felt in my guts
that this is not right thing to do anyway ... Metrics are going to be exposed
via CQL and adding more metrics into nodetool just feels wrong. I can revert
this whole change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
