Mmuzaf commented on code in PR #3002:
URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462080108
##########
src/java/org/apache/cassandra/tools/NodeProbe.java:
##########
@@ -1734,10 +1734,11 @@ public long getReadRepairRepairedBackground()
// JMX getters for the o.a.c.metrics API below.
/**
* Retrieve cache metrics based on the cache type (KeyCache, RowCache, or
CounterCache)
- * @param cacheType KeyCach, RowCache, or CounterCache
+ * @param type type, like Cache or UnweightedCache
+ * @param scope KeyCach, RowCache, or CounterCache
* @param metricName Capacity, Entries, HitRate, Size, Requests or Hits.
*/
- public Object getCacheMetric(String cacheType, String metricName)
+ public Object getCacheMetric(String type, String scope, String metricName)
Review Comment:
Since the `getCacheMetric` method isn't currently used for unweighted
caches, would it be better to roll back these changes and do it when the
nodetool needs it?
Another option is to create an overloaded `public Object getCacheMetric`
method that takes "Cache" as the first argument, this will help us avoid
changes that are not necessary right now. The weighted and unweighted caches
are slightly different anyway, so `getCacheMetric` is not quite what we want
(e.g. the `size` is different for weighted and unweighted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
