Mmuzaf commented on code in PR #3002: URL: https://github.com/apache/cassandra/pull/3002#discussion_r1462306773
########## src/java/org/apache/cassandra/metrics/UnweightedCacheMetrics.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.metrics; + +import com.codahale.metrics.Gauge; +import org.apache.cassandra.cache.UnweightedCacheSize; + +import static org.apache.cassandra.metrics.CassandraMetricsRegistry.Metrics; + +/** + * Metrics for an unweighted cache like {@code AuthCache}. + */ +public class UnweightedCacheMetrics extends AbstractCacheMetrics +{ + /** + * Cache capacity (maximum number of entries) + */ + public final Gauge<Integer> maxEntries; + + /** + * Total number of cache entries + */ + public final Gauge<Integer> entries; + + /** + * Create metrics for given cache. + * + * @param type Type of Cache to identify metrics + * @param cache Unweighted Cache to measure metrics + */ + public UnweightedCacheMetrics(String type, UnweightedCacheSize cache) + { + super(new DefaultNameFactory("UnweightedCache", type), type); + + maxEntries = Metrics.register(factory.createMetricName("Capacity"), cache::maxEntries); Review Comment: This will be exposed to an end user, however, as we don't have such metrics in the public API at this moment, we can expose it with the "right" name. Even though auth caches and weighted caches have different MBeans, vtables there is no need to keep the attribute names in sync between them, so I guess we can change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
