belliottsmith commented on code in PR #3432:
URL: https://github.com/apache/cassandra/pull/3432#discussion_r1693587198
##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -301,6 +300,13 @@ public void start(BiConsumer<? super R, Throwable>
callback)
{
Invariants.checkState(this.callback == null);
this.callback = callback;
+ if (commandStore.inStore())
Review Comment:
Fair point regarding execution failure though - I can refactor either to
share some execution logic (e.g. with a run method that can accept a highest
state to execute to), or else special-case this to replicate exit logic.
Whichever you have a preference for.
That said, the load logic is mostly asynchronous, so we'd be talking about
serious logic bugs I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
