belliottsmith commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1916222171


##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -366,9 +374,36 @@ public static RowIterator cas(String keyspaceName,
         }
 
         ConsensusAttemptResult lastAttemptResult;
+        Epoch lastEpoch = null;
         do
         {
+            if (lastEpoch != null)
+            {
+
+                long timeout = requestTime.computeTimeout(nanoTime(), 
DatabaseDescriptor.getTransactionTimeout(NANOSECONDS));
+                Epoch lastEpochFinal = lastEpoch;
+                
ClusterMetadataService.instance().log().highestPending().ifPresent(epoch ->
+                       {
+                           try
+                           {
+                               
ClusterMetadataService.instance().awaitAtLeast(epoch, timeout, NANOSECONDS);
+                           }
+                           catch (InterruptedException e)
+                           {
+                               throw new RuntimeException(e);

Review Comment:
   We shouldn't need to invoke Thread.interrupt(), but good catch point out the 
change to `UncheckedInterruptedException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to