dcapwell commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1915768362
##########
src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java:
##########
@@ -320,6 +330,17 @@ public UnfilteredRowIterator
applyToPartition(UnfilteredRowIterator partition)
return Transformation.apply(iterator, new Logging());
}
+ public static void log(UnfilteredPartitionIterator partitions, String id,
boolean fullDetails)
Review Comment:
to be clear, my issue isn't 100% with the double read, its the debug logic
that can't be enabled polluting production code... this type of thing happened
a lot in this patch and its something we should ask "do we want to maintain
this"... and in every case so far my answer is "no".
If you had a debug utility function that could take a `ReadResponse` and log
it, and its dead code, I would be ok with this (we would need to document that
this is a test debug utility, which is why its dead code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
