belliottsmith commented on code in PR #3777: URL: https://github.com/apache/cassandra/pull/3777#discussion_r1916232568
########## src/java/org/apache/cassandra/service/accord/AccordCallback.java: ########## @@ -32,6 +32,7 @@ import org.apache.cassandra.net.Message; import org.apache.cassandra.net.RequestCallback; +// TODO (review): Why is this unused now, should it be removed? Was it a mistake? Review Comment: Yeah, looks like I forgot to delete this. We use `RequestCallbacks` now and operate on native Accord callbacks, which have better expiration guarantees and also handle reporting of responses that are behind their predicted schedule so that we can try alternative replicas. We should consider eventually replacing the regular Cassandra callbacks with the Accord ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
