aweisberg commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1917053555
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -768,7 +775,17 @@ public TopologyManager topology()
public @Nonnull TxnResult coordinate(long minEpoch, @Nonnull Txn txn,
@Nonnull ConsistencyLevel consistencyLevel, @Nonnull Dispatcher.RequestTime
requestTime)
{
AsyncTxnResult asyncTxnResult = coordinateAsync(minEpoch, txn,
consistencyLevel, requestTime);
- return getTxnResult(asyncTxnResult, txn.isWrite(), consistencyLevel,
requestTime);
+ try
+ {
+ return getTxnResult(asyncTxnResult);
+ }
+ catch (TopologyMismatch e)
+ {
+ // For now assuming topology mismatch is caused by a race
misrouting
Review Comment:
The coordinator will throw IRE if the table doesn't exist, but I agree it
would be good to get rid of the duplicate loops and have the transaction logic
check if the `TopologyMismatch` is due to a table Accord just doesn't know
about yet.
I'll switch to doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
