aweisberg commented on code in PR #3777:
URL: https://github.com/apache/cassandra/pull/3777#discussion_r1917181876
##########
src/java/org/apache/cassandra/service/accord/txn/TxnWrite.java:
##########
@@ -392,7 +396,7 @@ public AsyncChain<Void> apply(Seekable key,
SafeCommandStore safeStore, TxnId tx
long timestamp = safeCfk.current().uniqueHlc(safeStore, txnId,
executeAt);
// TODO (low priority - do we need to compute nowInSeconds, or can we
just use executeAt?)
- int nowInSeconds = (int)
TimeUnit.MICROSECONDS.toSeconds(executeAt.hlc());
+ long nowInSeconds = (long)
TimeUnit.MICROSECONDS.toSeconds(executeAt.hlc());
Review Comment:
This is `long nowInSeconds = AccordSafeTimestampsForKey.nowInSecondsFor(cfk,
executeAt, true);` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]