dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985884288
##########
test/unit/org/apache/cassandra/cql3/conditions/ColumnConditionTest.java:
##########
@@ -930,11 +948,11 @@ private static
org.quicktheories.core.Gen<AbstractType<?>> selectTypes(ColumnCon
}
}
- private static Gen<ColumnCondition.Bound> boundGen()
+ public static Gen<ColumnCondition.Bound> boundGen()
{
Gen<ColumnCondition.BoundKind> kindGen =
Gens.enums().all(ColumnCondition.BoundKind.class);
Gen<Operator> operatorGen = Gens.enums().all(Operator.class);
- Gen<ByteBuffer> nonNullValuesGen =
Generators.toGen(Generators.bytes(1, 100));
+ Gen<ByteBuffer> nonNullValuesGen =
Generators.toGen(Generators.directAndHeapBytes(1, 100));
Review Comment:
this doesn't do the read only buffer types, those lead to jvm crashes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
