dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985836683
##########
src/java/org/apache/cassandra/service/accord/serializers/EnumSerializer.java:
##########
@@ -46,28 +44,19 @@ public E forOrdinal(int ordinal)
}
@Override
- public void serialize(E t, DataOutputPlus out, int version) throws
IOException
+ public void serialize(E t, DataOutputPlus out) throws IOException
{
out.writeUnsignedVInt32(t.ordinal());
}
@Override
- public E deserialize(DataInputPlus in, int version) throws IOException
+ public E deserialize(DataInputPlus in) throws IOException
{
return values[in.readUnsignedVInt32()];
}
- public ByteBuffer serialize(E e)
Review Comment:
the base interface now has this method, so all serializers get this by
default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
