dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985835132
##########
src/java/org/apache/cassandra/service/accord/AccordSerializers.java:
##########
@@ -232,41 +201,45 @@ public Clustering<?> deserialize(DataInputPlus in, int
version) throws IOExcepti
}
@Override
- public long serializedSize(Clustering<?> clustering, int version)
+ public long serializedSize(Clustering<?> clustering)
{
return computeSerializedSize(clustering);
}
private <V> long computeSerializedSize(Clustering<V> clustering)
{
- int size = sizeof(true) + sizeofUnsignedVInt(clustering.size());
Review Comment:
this was a bug found by this refactor. When we "embed" the bytes we were
not validating size == written like we do in networking; when you add that
validation you found this was failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
