dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985883541
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -395,12 +395,14 @@ protected void registerOutboundFilter(ICluster cluster)
MessagingService.instance().outboundSink.add((message, to) -> {
if (isShutdown())
return false; // TODO: Simulator needs this to trigger a
failure
- IMessage serialzied = serializeMessage(message.from(), to,
message);
int fromNum = config.num(); // since this instance is sending the
message, from will always be this instance
IInstance toInstance =
cluster.get(fromCassandraInetAddressAndPort(to));
if (toInstance == null)
return true; // TODO: Simulator needs this to trigger a failure
+ if (!cluster.filters().hasInbound() &&
!cluster.filters().hasOutbound())
Review Comment:
perf issue, tests would have no filtering yet we would spend a ton of time
deserializing to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
