dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985857166
##########
src/java/org/apache/cassandra/service/accord/txn/TxnUpdate.java:
##########
@@ -339,7 +339,7 @@ private static <T> List<T> deserialize(ByteBuffer bytes,
IVersionedSerializer<T>
try (DataInputBuffer in = new DataInputBuffer(bytes, true))
{
- int version = in.readUnsignedVInt32();
+ Version version = Version.fromVersion(in.readUnsignedVInt32());
Review Comment:
punted on fixing in this patch as its kinda annoying, so can try to fix
after the other open issues are addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
