dcapwell commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2017675195
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -90,18 +91,18 @@ public enum Field
{
PARTICIPANTS, // stored first so we can index it
SAVE_STATUS,
- PARTIAL_DEPS,
Review Comment:
is there a reason to shuffle this around? confirmed nothing was lost, but
journal does rely on `field.ordinal()` which makes this a breaking change; so
would like to know why we should reorder the fields
##########
accord-core/src/test/java/accord/impl/basic/LoggingJournal.java:
##########
@@ -73,6 +74,13 @@ private synchronized void log(String format, Object...
objects)
}
}
+ @Override
+
+ public Journal start(Node node)
+ {
+ return this;
+ }
Review Comment:
```suggestion
@Override
public Journal start(Node node)
{
delegate.start(node);
return this;
}
```
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -226,17 +229,17 @@ public Object get(Field field)
{
switch (field)
{
- case EXECUTE_AT: return executeAt;
Review Comment:
was there a reason for this refactor? looks like nothing was lost, but also
looks arbitrary?
##########
accord-core/src/main/java/accord/api/Journal.java:
##########
@@ -42,6 +43,8 @@
*/
public interface Journal
{
+ Journal start(Node node);
Review Comment:
Nothing consumes the result of this function, maybe drop `Journal` in favor
of `void`? `void` makes the semantics clear where as `Journal` "could" be a
different version.
<img width="477" alt="Screenshot 2025-03-27 at 3 23 11 PM"
src="https://github.com/user-attachments/assets/18c62139-9cfa-47a7-b468-22de73aaab3b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
