dcapwell commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2017726413
##########
accord-core/src/main/java/accord/coordinate/tracking/FastPathTracker.java:
##########
@@ -116,7 +116,7 @@ public final ShardOutcome<? super FastPathTracker>
onDelayed(@Nonnull Node.Id fr
++fastPathDelayed;
if (isFastPathDelayed() && hasReachedQuorum())
- return complete(Success);
+ return complete(hasMetMediumPathCriteria() ?
NewMediumPathSuccess : Success);
Review Comment:
this logic is duplicated in
`accord.coordinate.tracking.FastPathTracker.FastPathShardTracker#quorumIfHasRejectedFastPath`
can we cleanup so we don't have it scattered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
