dcapwell commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2017718126
##########
accord-core/src/main/java/accord/local/cfk/CommandsForKey.java:
##########
@@ -1603,35 +1603,33 @@ private CommandsForKeyUpdate update(InternalStatus
newStatus, Command updated, @
{
// update
TxnInfo cur = byId[pos];
- if (cur != null)
Review Comment:
for me:
`pos >= 0` so its known that the field isn't null, so this just removes the
`null` check; i couldn't find any lines that differ, just removed the if
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -701,8 +701,8 @@ public void markShardDurable(SafeCommandStore safeStore,
TxnId globalSyncId, Ran
protected void updatedRedundantBefore(SafeCommandStore safeStore, TxnId
syncId, Ranges ranges)
{
TxnId clearWaitingBefore =
redundantBefore.minShardAndLocallyAppliedBefore();
- TxnId clearAnyBefore = durableBefore().min.majorityBefore;
- progressLog.clearBefore(safeStore, clearWaitingBefore, clearAnyBefore);
+ TxnId clearAllBefore = TxnId.min(clearWaitingBefore,
durableBefore().min.majorityBefore);
Review Comment:
why push this change here? it looked to happen in default progress log
before now its an assert and the logic moved here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
