dcapwell commented on code in PR #4107:
URL: https://github.com/apache/cassandra/pull/4107#discussion_r2054842160
##########
src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java:
##########
@@ -52,6 +52,7 @@ public class LeveledCompactionStrategy extends
AbstractCompactionStrategy
public static final String LEVEL_FANOUT_SIZE_OPTION = "fanout_size";
public static final String SINGLE_SSTABLE_UPLEVEL_OPTION =
"single_sstable_uplevel";
public static final int DEFAULT_LEVEL_FANOUT_SIZE = 10;
+ public static final int DEFAULT_MAX_SSTABLE_SIZE_MIB = 160;
Review Comment:
from https://github.com/apache/cassandra/pull/4105
##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -217,8 +217,8 @@ private void flushVectorIndex(long startTime, Stopwatch
stopwatch) throws IOExce
private void completeIndexFlush(long cellCount, long startTime, Stopwatch
stopwatch) throws IOException
{
- // create a completion marker indicating that the index is complete
and not-empty
- ColumnCompletionMarkerUtil.create(indexDescriptor, indexIdentifier,
false);
+ // create a completion marker indicating that the index is complete
+ ColumnCompletionMarkerUtil.create(indexDescriptor, indexIdentifier,
cellCount == 0);
Review Comment:
from https://github.com/apache/cassandra/pull/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
