dcapwell commented on code in PR #4107:
URL: https://github.com/apache/cassandra/pull/4107#discussion_r2056700369


##########
test/unit/org/apache/cassandra/utils/CassandraGenerators.java:
##########
@@ -309,9 +311,8 @@ public static Gen<String> sstableFormatNames()
 
     public static Gen<SSTableFormat<?, ?>> sstableFormat()
     {
-        // make sure ordering is determanstic, else repeatability breaks
-        NavigableMap<String, SSTableFormat<?, ?>> formats = new 
TreeMap<>(DatabaseDescriptor.getSSTableFormats());
-        return SourceDSL.arbitrary().pick(new ArrayList<>(formats.values()));
+        return SourceDSL.arbitrary().pick(new BigFormat(Map.of()),

Review Comment:
   this is just making sure that the config doesn't alter the random history; 
we only allow BIG/BTI atm and not anything randomly included



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to