dcapwell commented on code in PR #4107: URL: https://github.com/apache/cassandra/pull/4107#discussion_r2054844590
########## test/distributed/org/apache/cassandra/distributed/test/sai/PartialWritesWithRepairTest.java: ########## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.test.sai; + +import org.apache.cassandra.dht.Murmur3Partitioner; +import org.apache.cassandra.distributed.Cluster; +import org.apache.cassandra.distributed.api.Feature; +import org.apache.cassandra.distributed.api.IInvokableInstance; +import org.apache.cassandra.distributed.shared.ClusterUtils; +import org.apache.cassandra.distributed.shared.ClusterUtils.Range; +import org.apache.cassandra.distributed.test.TestBaseImpl; +import org.junit.Test; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.List; + +public class PartialWritesWithRepairTest extends TestBaseImpl Review Comment: from https://github.com/apache/cassandra/pull/4105 ########## test/distributed/org/apache/cassandra/fuzz/sai/AccordFullMultiNodeSAITest.java: ########## @@ -25,7 +25,7 @@ import org.apache.cassandra.harry.gen.SchemaGenerators; import org.apache.cassandra.service.consensus.TransactionalMode; -@Ignore("CASSANDRA-20567: Repair is failing due to missing SAI index files when using zero copy streaming") +@Ignore("It was believed that these tests were failing due to CASSANDRA-20567, but in fixing that issue it was found that the tests are still failing! Harry is detecting an incorrect response...") Review Comment: from https://github.com/apache/cassandra/pull/4105 ########## test/distributed/org/apache/cassandra/fuzz/sai/AccordInteropMultiNodeSAITest.java: ########## @@ -25,7 +25,7 @@ import org.apache.cassandra.harry.gen.SchemaGenerators; import org.apache.cassandra.service.consensus.TransactionalMode; -@Ignore("CASSANDRA-20567: Repair is failing due to missing SAI index files when using zero copy streaming") +@Ignore("It was believed that these tests were failing due to CASSANDRA-20567, but in fixing that issue it was found that the tests are still failing! Harry is detecting an incorrect response...") Review Comment: from https://github.com/apache/cassandra/pull/4105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
