dcapwell commented on code in PR #4107:
URL: https://github.com/apache/cassandra/pull/4107#discussion_r2054843352
##########
src/java/org/apache/cassandra/io/sstable/SSTableZeroCopyWriter.java:
##########
@@ -233,4 +236,20 @@ private void write(AsyncStreamingInputPlus in, long size,
SequentialWriter write
throw new FSWriteError(e, writer.getPath());
}
}
+
+ private static class ZeroCopySequentialWriter extends SequentialWriter
+ {
+ private ZeroCopySequentialWriter(File file, SequentialWriterOption
option, boolean strictFlushing)
+ {
+ super(file, ByteBufferUtil.EMPTY_BYTE_BUFFER, option,
strictFlushing);
+ }
+
+ @Override
+ public void write(byte[] b, int off, int len) throws IOException
Review Comment:
I can't actually find a single code path that hits this outside of unit
tests... trying to see what production configs or conditions hit this, but as
far as i can tell we hard code the async channel in netty, so this is a test
only code path?
##########
test/distributed/org/apache/cassandra/distributed/shared/ClusterUtils.java:
##########
@@ -1646,4 +1639,41 @@ public static void awaitAccordEpochReady(Cluster
cluster, long epoch)
});
});
}
+
+ @Shared
+ public static class Range implements Serializable
+ {
+ public final String left, right;
+
+ public Range(String left, String right)
+ {
+ this.left = left;
+ this.right = right;
+ }
+
+ public Range(long left, long right)
+ {
+ this(Long.toString(left), Long.toString(right));
+ }
+
+ public long left()
+ {
+ return Long.parseLong(left);
+ }
+
+ public long right()
+ {
+ return Long.parseLong(right);
+ }
+ }
+
+ public static List<Range> getPrimaryRanges(IInvokableInstance instance,
String keyspace)
Review Comment:
from https://github.com/apache/cassandra/pull/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
