dcapwell commented on code in PR #4107:
URL: https://github.com/apache/cassandra/pull/4107#discussion_r2056670509
##########
src/java/org/apache/cassandra/io/sstable/SSTableZeroCopyWriter.java:
##########
@@ -233,4 +237,22 @@ private void write(AsyncStreamingInputPlus in, long size,
SequentialWriter write
throw new FSWriteError(e, writer.getPath());
}
}
+
+ private static class ZeroCopySequentialWriter extends SequentialWriter
+ {
+ private ZeroCopySequentialWriter(File file, SequentialWriterOption
option, boolean strictFlushing)
+ {
+ super(file, ByteBufferUtil.EMPTY_BYTE_BUFFER, option,
strictFlushing);
Review Comment:
this is the core change to fix the OOM, use the empty BB rather than
allocate one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
