belliottsmith commented on code in PR #187:
URL: https://github.com/apache/cassandra-accord/pull/187#discussion_r2100277256
##########
accord-core/src/main/java/accord/coordinate/ExecuteTxn.java:
##########
@@ -236,8 +236,9 @@ protected void onDone(Success success, Throwable failure)
executeAt = new TimestampWithUniqueHlc(executeAt, uniqueHlc);
}
- Writes writes = txnId.is(Txn.Kind.Write) ? txn.execute(txnId,
executeAt, data) : null;
+ // Always compute Result before Write
Review Comment:
Explain why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
