belliottsmith commented on code in PR #187:
URL: https://github.com/apache/cassandra-accord/pull/187#discussion_r2100333045
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -687,6 +687,12 @@ public TxnId nextTxnId(Txn.Kind rw, Domain domain,
Cardinality cardinality)
return nextTxnId(rw, domain, cardinality, defaultMediumPath().bit());
}
+ public TxnId nextTxnId(Txn.Kind rw, Domain domain, Cardinality
cardinality, long minHlc)
+ {
+ Timestamp minTimestamp = Timestamp.fromValues(topology.epoch(),
minHlc, 0, id());
Review Comment:
might also be more consistent to accept minHlc as first parameter to match
Timestamp min variant below? Or could perhaps introduce a nextTxnId(minEpoch,
minHlc, ... to accept both of these variants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
