belliottsmith commented on code in PR #187:
URL: https://github.com/apache/cassandra-accord/pull/187#discussion_r2100335435
##########
accord-core/src/main/java/accord/local/SafeCommandStore.java:
##########
@@ -303,6 +305,11 @@ public void updateMaxConflicts(Command prev, Command
updated)
commandStore().updateMaxConflicts(prev, updated);
}
+ public long maxHLCForSeekables(Routables<?> keysOrRanges)
Review Comment:
simply `maxHlc`? You're accepting `Routables` not `Seekables` and including
the type isn't probably necessary anyway. Mostly we have lower cased the `lc`
in `Hlc` so far in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
