belliottsmith commented on code in PR #187:
URL: https://github.com/apache/cassandra-accord/pull/187#discussion_r2100317683
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -625,6 +625,10 @@ public AsyncChain<Void> forEach(Consumer<SafeCommandStore>
forEach)
Snapshot snapshot = current;
for (ShardHolder shard : snapshot.shards)
list.add(shard.store.build(empty(), forEach));
+
+ if (list.isEmpty())
Review Comment:
I wonder if we should remove the variants of `AsyncChains.reduce` that don't
accept `identity` and use this version here. It's a bit brittle, the lack of
properly handling no inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
