aweisberg commented on code in PR #187:
URL: https://github.com/apache/cassandra-accord/pull/187#discussion_r2121834622
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -625,6 +625,10 @@ public AsyncChain<Void> forEach(Consumer<SafeCommandStore>
forEach)
Snapshot snapshot = current;
for (ShardHolder shard : snapshot.shards)
list.add(shard.store.build(empty(), forEach));
+
+ if (list.isEmpty())
Review Comment:
I think that makes sense to an extent, but it does require that the reducer
accept `null` and handle it by returning the non-null parameter? Or for
everything to have a non-null identity that can be handled correctly. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
