belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2184726275


##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -699,6 +699,15 @@ protected boolean shouldBootstrap(Node node, Topology 
local, Topology newLocalTo
         return newLocalTopology.epoch() != 1;
     }
 
+    public AsyncChain<?> rebootstrap(Node node)
+    {
+        List<AsyncChain<?>> results = new ArrayList<>();
+        Snapshot snapshot = current;
+        for (ShardHolder shard : snapshot.shards)
+            results.add(shard.store.rebootstrap(node, 
shard.ranges.currentRanges(), snapshot.global.epoch()));

Review Comment:
   We may rebootstrap because we're _behind_ in some cases (not because replay 
has failed), and in this case we will know which ranges we might be behind on, 
and so can target the rebootstrap. So, I think it would be helpful to be able 
to target just a given sub-range even with a command store?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to