belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218734305
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -895,4 +938,11 @@ public NodeCommandStoreService node()
{
return node;
}
+
+ /**
+ * Thrown when command store is not ready to serve the request for a given
range.
+ */
+ public static class NotReadyException extends RuntimeException
Review Comment:
I think NotReady is perhaps the wrong name for this, since we will never be
ready, unless I misunderstand the context. The point is we don't have the
relevant log history anymore. The best we can ever hope to respond with is
Vestigial. The only reason we might not convert immediately to Vestigial is
that a transaction may only partially overlap the rebootstrap, so we need to
support maintaining some local state for the transaction in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
