belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218701320
##########
accord-core/src/main/java/accord/coordinate/ExecuteEphemeralRead.java:
##########
@@ -233,6 +233,23 @@ protected boolean cancel()
return true;
}
+ @Override
+ protected void onFailure(CommitOrReadNack failReply, Throwable
throwable)
Review Comment:
why duplicate this? Is this to address the double invocation of callback, so
we can call super.cancel? If so, I think it would be better to fix this by
changing the cancel override to instead override timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
