belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218753348
##########
accord-core/src/main/java/accord/local/RedundantStatus.java:
##########
@@ -159,6 +166,7 @@ public static class SomeStatus
public static final SomeStatus MAJORITY_APPLIED_ONLY =
oneSlow(MAJORITY_APPLIED);
public static final SomeStatus SHARD_APPLIED_ONLY =
oneSlow(SHARD_APPLIED);
public static final SomeStatus GC_BEFORE_AND_LOCALLY_APPLIED =
multi(GC_BEFORE, LOCALLY_APPLIED);
+ public static final SomeStatus SHARD_UNSAFE_BEFORE =
oneSlow(UNSAFE_BEFORE);
Review Comment:
definitely not SHARD unsafe, in this class SHARD refers to a whole shard
property. We mean LOCALLY_UNSAFE or perhaps better would be LOCALLY_CORRUPT or
LOCALLY_LOST or LOCALLY_INCOMPLETE. This should be consistent with the Property
name, and be suffixed with _ONLY here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
