belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218745101
##########
accord-core/src/main/java/accord/local/RedundantBefore.java:
##########
@@ -924,6 +936,22 @@ public boolean isShardOnlyApplied(TxnId txnId,
Unseekables<?> participants)
return foldl(participants, Bounds::isShardOnlyApplied, false, txnId);
}
+ public boolean isUnsafeBefore(TxnId txnId, Unseekables<?> participants)
+ {
+ // Definitely safe
+ if (maxUnsafeBefore == TxnId.NONE)
+ return false;
+
+ // TODO: Problem is that, logically, we do know that transactions
after maxUnsafeBefore (txnId.compareTo(maxUnsafeBefore) > 0)
Review Comment:
Is this still true? Because if so we need to understand it, and using a
weaker comparison here shouldn't have any bearing on that fact, as it should
only decide whether we invoke the below foldl which provides the more precise
answer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
